Open
Conversation
This also fixes a big bubu that was in the non JITed kernel Signed-off-by: uzerbianati <zerbinati@maths.ox.ac.uk>
pbrubeck
force-pushed
the
pbrubeck/fix/mg
branch
from
14a5ae9 to
0df0583
Compare
pbrubeck
force-pushed
the
pbrubeck/fix/mg
branch
from
0df0583 to
9c625f0
Compare
Collaborator
Collaborator
|
Its due to: |
pbrubeck
force-pushed
the
pbrubeck/fix/mg
branch
from
d9de24f to
3d197ce
Compare
pbrubeck
force-pushed
the
pbrubeck/fix/mg
branch
from
3d197ce to
f2dde21
Compare
pbrubeck
force-pushed
the
pbrubeck/fix/mg
branch
from
0229b3b to
abd7e3d
Compare
pbrubeck
force-pushed
the
pbrubeck/fix/mg
branch
11 times, most recently
from
c0fda51 to
7360aa1
Compare
pbrubeck
force-pushed
the
pbrubeck/fix/mg
branch
3 times, most recently
from
28b953c to
ec56bde
Compare
pbrubeck
force-pushed
the
pbrubeck/fix/mg
branch
from
ec56bde to
4ce155d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tidy up plex.py.
The current mechanism to convert a plex into netgen breaks for CSG geometries, (we can construct a mesh but are unable to snap the vertices to the geometry). Here we simply throw a
ValueErrorif the provided geometry is notOCCGeometry.